Skip to content

[SC 8983] Remove inferring datatype warnings#336

Merged
AnilSorathiya merged 9 commits intomainfrom
anilsorathiya/sc-8983/remove-ydata-profiling-library-dependency
Mar 11, 2025
Merged

[SC 8983] Remove inferring datatype warnings#336
AnilSorathiya merged 9 commits intomainfrom
anilsorathiya/sc-8983/remove-ydata-profiling-library-dependency

Conversation

@AnilSorathiya
Copy link
Contributor

Internal Notes for Reviewers

Remove warning message:

/../../developer-framework/validmind/utils.py:639: UserWarning:

This pattern is interpreted as a regular expression, and has match groups. To actually get the groups, use str.extract.

@AnilSorathiya AnilSorathiya added the internal Not to be externalized in the release notes label Mar 11, 2025
@github-actions
Copy link
Contributor

PR Summary

This pull request enhances the regular expression pattern used to identify file paths in the validmind/utils.py file. The changes are made in two functions: is_text_column and _get_text_type_detail. The modification involves updating the filepath regex pattern from using capturing groups to non-capturing groups. This change is intended to improve the accuracy and performance of the regex matching by avoiding unnecessary capturing of groups when it is not needed.

Test Suggestions

  • Test the updated regex pattern with various file paths to ensure it correctly identifies valid paths.
  • Include edge cases such as paths with special characters, different drive letters, and network paths.
  • Verify that the regex does not match invalid file paths.
  • Check the performance of the regex pattern on large datasets to ensure no significant degradation.

Copy link
Contributor

@johnwalz97 johnwalz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AnilSorathiya AnilSorathiya changed the title [SC 8983] Remove while inferring datatype [SC 8983] Remove inferring datatype warnings Mar 11, 2025
@AnilSorathiya AnilSorathiya merged commit 8a538d3 into main Mar 11, 2025
7 checks passed
@johnwalz97 johnwalz97 deleted the anilsorathiya/sc-8983/remove-ydata-profiling-library-dependency branch August 20, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants